Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue: connection leak risk when using Nacos data-source. #2962

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

pandaapo
Copy link
Contributor

Describe what this PR does / why we need it

Connection in NacosDataSource exists leak risk.

Does this pull request fix one issue?

Fixes #2953

Describe how you did it

ConfigService#shutDown() when NacosDataSource#close().

Describe how to verify it

Special notes for reviews

@sczyh30 sczyh30 added the area/data-source Issues or PRs related to data-source extension label Nov 21, 2022
@sczyh30
Copy link
Member

sczyh30 commented Nov 21, 2022

cc @KomachiSion

@sczyh30 sczyh30 added the to-review To review label Nov 30, 2022
@sczyh30 sczyh30 added the kind/bug Category issues or prs related to bug. label Jan 5, 2023
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit a63fea3 into alibaba:master Jan 5, 2023
@sczyh30
Copy link
Member

sczyh30 commented Jan 5, 2023

Thanks for contributing!

For better solution, we may consider reusing the single ConfigService for all NacosDataSource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-source Issues or PRs related to data-source extension kind/bug Category issues or prs related to bug. to-review To review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connection leak risk when using Nacos data-source | Nacos 数据源 close 存在连接泄漏问题
2 participants